Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide arguments to NewGitServer and NewGitProtocol as Opts structs #13

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

lhchavez
Copy link
Member

@lhchavez lhchavez commented Dec 1, 2021

There are now way too many arguments for these functions, so let's do a
small API-breaking change to make it easier to extend. #major

There are now way too many arguments for these functions, so let's do a
small API-breaking change to make it easier to extend. #major
@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #13 (d2c1b6b) into main (81c647d) will increase coverage by 1.37%.
The diff coverage is 67.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   53.10%   54.47%   +1.37%     
==========================================
  Files           7        8       +1     
  Lines        2000     2135     +135     
==========================================
+ Hits         1062     1163     +101     
- Misses        730      746      +16     
- Partials      208      226      +18     
Impacted Files Coverage Δ
commits.go 58.07% <40.00%> (+0.03%) ⬆️
browser.go 52.29% <48.14%> (-0.13%) ⬇️
keyedpool.go 78.12% <78.12%> (ø)
protocol.go 62.78% <78.94%> (-0.21%) ⬇️
server.go 21.37% <81.81%> (-0.16%) ⬇️
packfile.go 55.12% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 261b874...d2c1b6b. Read the comment docs.

@lhchavez lhchavez merged commit e121b6e into main Dec 1, 2021
@lhchavez lhchavez deleted the gitserver-opts branch December 1, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant