fix: prevent bessctl hanging on SystemExit #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dario Faccin <[email protected]>
gatici
approved these changes
Jul 10, 2024
|
This PR is necessary to terminate the process on CLI in case errors are occurred. Otherwise, CLI just hangs and nothing can go forward. |
sureshmarikkannu
approved these changes
Jul 10, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix
bessctlcommand hanging in some cases.The original issue is tracked by canonical/sdcore-upf-operator#92.
The usage of
os._exit(n)is not encouraged as exit handlers are not called and stdio buffer streams are not flushed; however, in this case, nothing is to be performed after this point.