exact match & wildcard test case issue resolution/updation #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gab-arrobo
reviewed
Feb 22, 2024
5 tasks
amarsri28
commented
Feb 27, 2024
|
@amarsri28 please rebase this branch |
gab-arrobo
approved these changes
Mar 8, 2024
gab-arrobo
reviewed
Mar 9, 2024
Comment on lines
+143
to
+169
| #def test_wildcardmatch_selfconfig(self): | ||
| # "make sure get_initial_arg and [gs]et_runtime_config work" | ||
| # iconf = { | ||
| # 'fields': [{'attr_name': 'babylon5', 'num_bytes': 2}, | ||
| # {'offset': 10, 'num_bytes': 1}] | ||
| # } | ||
| # wm = WildcardMatch(**iconf) | ||
| # # workers are all paused, we never run them here | ||
| # m1 = vstring([0xff, 0xf0], [0x7f]) | ||
| # v1 = vstring([0x88, 0x80], [0x03]) | ||
| # wm.add(gate=1, priority=1, masks=m1, values=v1) | ||
| # m2 = vstring([0xf0, 0xff], [0x3f]) | ||
| # v2 = vstring([0x70, 0x70], [0x05]) | ||
| # wm.add(gate=2, priority=2, masks=m2, values=v2) | ||
| # wm.set_default_gate(gate=3) | ||
| # # Delivered config is sorted by priority, then gate, then mask, | ||
| # # then values. Since we use a different priority for each we can | ||
| # # just sort by priority here. | ||
| # expect_config = { | ||
| # 'default_gate': 3, | ||
| # 'rules': [ | ||
| # {'priority': 1, 'gate': 1, 'masks': m1, 'values': v1}, | ||
| # {'priority': 2, 'gate': 2, 'masks': m2, 'values': v2}, | ||
| # ] | ||
| # } | ||
| # arg = pb_conv.protobuf_to_dict(wm.get_initial_arg()) | ||
| # cur_config = pb_conv.protobuf_to_dict(wm.get_runtime_config()) |
There was a problem hiding this comment.
@amarsri28, please open an issue about this so we keep track of it. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pr will enable test cases for exact-match & Wildcard. one common test case is still not working so it has been disabled for now.