packet drop issue resolution #30
Conversation
| int64_t jitter = diff - last_rtt_ns_; | ||
| jitter = jitter * ((jitter>0) - (jitter<0)); |
There was a problem hiding this comment.
Why not just use the abs?
| int64_t jitter = diff - last_rtt_ns_; | |
| jitter = jitter * ((jitter>0) - (jitter<0)); | |
| int64_t jitter = abs(diff - last_rtt_ns_); |
Of course, the above would need to include <cstdlib> if needed
There was a problem hiding this comment.
suggested change in line 138 wont work/compile as abs dnt work on atomics. latest patch has that change.
| int64_t jitter = diff - last_rtt_ns_; | ||
| jitter = jitter * ((jitter>0) - (jitter<0)); |
There was a problem hiding this comment.
You need to apply clang-format to address the GHA issue
There was a problem hiding this comment.
covered in latest pr
| int64_t jitter = diff - last_rtt_ns_; | ||
| jitter = jitter * ((jitter>0) - (jitter<0)); |
There was a problem hiding this comment.
Moreover, why do you have to change jitter to int64_t given that the argument for jitter_hist_.AtomicInsert() is uint64_t?
There was a problem hiding this comment.
In this context, suggested change wont work as uint64_t wont be able to save negative values .
|
@amarsri28, any update about this PR? |
This is preliminary patch .