Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api_experimenters_groups #148

Merged
merged 14 commits into from
Jul 10, 2020
Merged

Conversation

will-moore
Copy link
Member

@will-moore will-moore commented Mar 6, 2020

Ported from PR ome/openmicroscopy#5315

This is needed for #149 .

This requires ome/omero-py#196 (merged - required as omero-py 5.7.0)

To test:

  • Browse to /api/v0/m/experimenters/ to list all.
  • filter with ?experimentergroup=3 or with /api/v0/m/experimentergroups/3/experimenters
  • Browse to /api/v0/m/experimentergroups/ to list all.
  • filter groups with ?experimenter=3 or with /api/v0/m/experimenters/3/experimentergroups
  • Follow links to see single experimenter or group: /api/v0/m/experimenters/3/ or /api/v0/m/experimentergroups/3/

NB: elsewhere we use ?group=1 to filter objects by permissions.
But experimenters don't have permissions and we are filtering by links, so we use ?experimentergroup=3 in the same way as we do /images/?dataset=3.
Hopefully not too confusing, but I think that is logically correct.

@will-moore will-moore changed the title Ported omero-web code from api_experimenters_groups api_experimenters_groups Mar 6, 2020
@will-moore will-moore mentioned this pull request Mar 12, 2020
@jburel
Copy link
Member

jburel commented Jun 9, 2020

I tested the various queries yesterday and they worked.

omeroweb/api/views.py Outdated Show resolved Hide resolved
@jburel
Copy link
Member

jburel commented Jul 2, 2020

thanks @will-moore, looks good
for the changelog, change of version of omero-py

@will-moore
Copy link
Member Author

OK, I'll open a changelog PR...

@will-moore will-moore mentioned this pull request Jul 6, 2020
@will-moore
Copy link
Member Author

Changelog PR at #185
This PR doesn't have 5.7.0 milestone yet

@sbesson sbesson added this to the 5.7.0 milestone Jul 6, 2020
@jburel jburel merged commit 03162ab into ome:master Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants