-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api_experimenters_groups #148
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will-moore
changed the title
Ported omero-web code from api_experimenters_groups
api_experimenters_groups
Mar 6, 2020
will-moore
force-pushed
the
api_experimenters_groups
branch
from
March 6, 2020 15:42
485de7c
to
1c2de93
Compare
Merged
Merged
jburel
reviewed
Jun 8, 2020
jburel
reviewed
Jun 8, 2020
I tested the various queries yesterday and they worked. |
jburel
reviewed
Jun 9, 2020
sbesson
reviewed
Jun 19, 2020
jburel
reviewed
Jul 1, 2020
thanks @will-moore, looks good |
OK, I'll open a changelog PR... |
Merged
Changelog PR at #185 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported from PR ome/openmicroscopy#5315
This is needed for #149 .
This requires ome/omero-py#196 (merged - required as omero-py 5.7.0)
To test:
/api/v0/m/experimenters/
to list all.?experimentergroup=3
or with/api/v0/m/experimentergroups/3/experimenters
/api/v0/m/experimentergroups/
to list all.?experimenter=3
or with/api/v0/m/experimenters/3/experimentergroups
/api/v0/m/experimenters/3/
or/api/v0/m/experimentergroups/3/
NB: elsewhere we use
?group=1
to filter objects by permissions.But experimenters don't have permissions and we are filtering by links, so we use
?experimentergroup=3
in the same way as we do/images/?dataset=3
.Hopefully not too confusing, but I think that is logically correct.