Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gh action #39

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Update gh action #39

merged 2 commits into from
Oct 28, 2024

Conversation

jburel
Copy link
Member

@jburel jburel commented Oct 25, 2024

This PR updates the github workflow
It matches the changes made in https://github.com/ome/ome2024-ngff-challenge/blob/main/.github/workflows/pages.yml

@jburel jburel requested a review from will-moore October 25, 2024 13:20
Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for ome-ngff-validator ready!

Name Link
🔨 Latest commit c60aac4
🔍 Latest deploy log https://app.netlify.com/sites/ome-ngff-validator/deploys/671b9b167f31b400082d1d72
😎 Deploy Preview https://deploy-preview-39--ome-ngff-validator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@will-moore will-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - corresponds to changes we have at https://github.com/ome/ome2024-ngff-challenge/blob/main/.github/workflows/pages.yml
(except there we have uses: actions/[email protected] instead of 4.2.1)

@joshmoore
Copy link
Member

Getting this in now to be sure things keep working for tomorrow.

@joshmoore joshmoore merged commit 24f187f into ome:main Oct 28, 2024
5 checks passed
@joshmoore
Copy link
Member

Doh 🤦🏽 I was thinking this was on the sample viewer. Apologies, but I assume it won't cause issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants