-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transforms support #32
Conversation
✅ Deploy Preview for ome-ngff-validator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cc @joshmoore - know any good samples for testing? |
Thanks @joshmoore for tagging. Unfortunately the datasets linked could be some good starting points (and especially the code to generate variations of them), but they don't agree 100% to the current specs. As discussed here: scverse/spatialdata#35 we wanted to wait until the transformation PR got merged, but unfortunately it didn't happen. |
Testing a bunch of invalid sample files, validation is working but I find the errors can be a bit verbose. The useful ones are:
|
I tried adding an invalid
The schema that contains |
cc: @bogovicj but I think, @LucaMarconato, that it would now be a good time to tackle this. |
@will-moore: I've updated the title to be "Transforms supports" rather than v0.5. I leave it up to you whether to change the usages internally or if we just close for the moment. |
I'll close for now, thx |
Adding support for ome/ngff#138
Since that PR isn't merged yet, we need custom URL for loading schemas from that branch.
This PR build is deployed at https://deploy-preview-32--ome-ngff-validator.netlify.app - but I don't know of good sample data to test with.
To test a sample file containing various example snippets from the PR above see https://deploy-preview-32--ome-ngff-validator.netlify.app/?source=https://minio-dev.openmicroscopy.org/idr/v0.5/idr0050/4995115.zarr
NB: this is valid according to the proposed schemas, but won't make any sense to a viewer client.
I'm not loading some schemas, such as
coordinate_systems_and_transforms.schema
andcoordinateTransformations.schema
. I'm don't see that they are needed by any validation yet, but I've not tried much.Also the strict schemas aren't used (same as before).