Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D3 config table adding row #135

Open
wants to merge 2 commits into
base: Discon3
Choose a base branch
from

Conversation

lostcarpark
Copy link

Changes to fix issue #134.

For Rooms table, changed insert logic in SubmitEditConfigTable.php to check for empty string in column, and insert NULL instead.

For RoomHasSet, changes using drop-downs were not saving, as label was being inserted when selecting an item. Changed values in editorParams from array of [id: name] keys to [{ label: name, value: id }] objects. The drop-down now correctly inserts the value instead of the label into the grid data.

@LVerhulst4321
Copy link
Collaborator

I've put this change into my installation and can confirm that it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants