Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub actions to test ESP builds as a automated merge check for PRs #155

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

tmcadam
Copy link
Collaborator

@tmcadam tmcadam commented Apr 14, 2024

This contains a simple github action that runs a pio run on pushes to either main or any branch beginning with dev-esp. This will test that all ESP targets compile. This can be configured as a branch protection for main meaning any PR to main must have a successful run of this action, before the merge button is enabled (override is possible by admins).

The binaries produced by pio run are discarded.

Based on:
https://docs.platformio.org/en/stable/integration/ci/github-actions.html#using-cmd-run-command

Other automated checks we could consider are:

  • run the same check with the stm32 tergets
  • check that debug is disabled in all hal files

This has been tested and is ready to merge. Once merged it won't have any impact on current workflows until enabled as a branch protection in the Github GUI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant