perf: filter toMany select relations with where #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than filtering results when selecting a toMany relation ensure that the relation is filtered using a modified where object in the query. This was previously difficult due to the nature of the select action: it was impossible to distinguish between an include.select and a relational select action. Upgrading to v4 of prisma-nested-middleware removes the include.select variant of the select action, allowing this library to remove the logic that deferred select actions within an include to the parent action. That logic that deferred to the parent also prevented always modifying the select action to use the where strategy.
|
🎉 This PR is included in version 1.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than filtering results when selecting a toMany relation ensure that the relation is filtered using a modified where object in the query.
This was previously difficult due to the nature of the select action: it was impossible to distinguish between an include.select and a relational select action.
Upgrading to v4 of prisma-nested-middleware removes the include.select variant of the select action, allowing this library to remove the logic that deferred select actions within an include to the parent action. That logic that deferred to the parent also prevented always modifying the select action to use the where strategy.