fix: changing operation in $rootOperation #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In $rootOperation the only way to change the operation type is to use the previous client; in $allNestedOperations we are able to manipulate the args that are passed to the query, but in $rootOperation there is no API for switching the operation type of the query function. Currently if the $rootOperation does not call the query function then the query hangs, this is because we are awaiting the query function in the $allOperations hook generated by withNestedOperations. Replace the execution of the $rootOperation with a straight call to $rootOperation as we don't need to track any aspect of its execution.
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In $rootOperation the only way to change the operation type is to use the previous client; in $allNestedOperations we are able to manipulate the args that are passed to the query, but in $rootOperation there is no API for switching the operation type of the query function.
Currently if the $rootOperation does not call the query function then the query hangs, this is because we are awaiting the query function in the $allOperations hook generated by withNestedOperations.
Replace the execution of the $rootOperation with a straight call to $rootOperation as we don't need to track any aspect of its execution.