Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whf/add genesis #138

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Whf/add genesis #138

wants to merge 4 commits into from

Conversation

zibuyu28
Copy link

@zibuyu28 zibuyu28 commented Sep 4, 2024

No description provided.

@@ -17,6 +17,7 @@ import (
// if there is no new fully downloaded batch - do not short circuit
// returns (shouldShortCircuit, blockNumber, error)
func ShouldShortCircuitExecution(tx kv.RwTx, logPrefix string) (bool, uint64, error) {
return false, 0, nil
Copy link

@zjg555543 zjg555543 Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should delete this debug code.

@@ -0,0 +1,26 @@

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it add a readme file to discribe how to use these files step one by one?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants