Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prometheus client & seq metrics & Block/Batch Info #122

Open
wants to merge 33 commits into
base: dev
Choose a base branch
from
Open

Add prometheus client & seq metrics & Block/Batch Info #122

wants to merge 33 commits into from

Conversation

bylingo
Copy link

@bylingo bylingo commented Aug 19, 2024

  • Add prometheus client and corresponding flags
  • Add Sequencer metrics : BatchExecutionTime, PoolTxCount
  • Add Block Log and Batch Log for every batch execution

sieniven
sieniven reviewed Aug 21, 2024
View reviewed changes
Copy link

@sieniven sieniven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add comments "// For X Layer metrics" in all sequencer pipeline when adding in X Layer metrics for easier reference, especially when maintaining with upstream repo

cmd/cdk-erigon/run_xlayer.go Outdated Show resolved Hide resolved
zk/seqlog/seqlog_block.go Outdated Show resolved Hide resolved
zk/seqlog/seqlog_batch.go Outdated Show resolved Hide resolved
zk/stages/stage_sequence_execute.go Outdated Show resolved Hide resolved
zk/stages/stage_sequence_execute.go Outdated Show resolved Hide resolved
zjg555543
zjg555543 reviewed Sep 4, 2024
View reviewed changes
zk/seqlog/seqlog_batch.go Outdated Show resolved Hide resolved
zjg555543
zjg555543 reviewed Sep 4, 2024
View reviewed changes
test/config/test.erigon.rpc.config.yaml
@@ -46,7 +46,25 @@ http.addr: 0.0.0.0
http.port: 8545
http.vhosts: any
http.corsdomain: any
http.timeouts.read: "10s"
http.timeouts.write: "10s"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a smoke E2E test with the metrics API .

@zjg555543
Copy link

Recommit by #140

@zjg555543 zjg555543 mentioned this pull request Sep 12, 2024
Merged
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open for 40 days with no activity.

@github-actions github-actions bot added the Stale label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sieniven sieniven sieniven left review comments

@zjg555543 zjg555543 zjg555543 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bylingo @zjg555543 @sieniven @zibuyu28