This repository has been archived by the owner on Dec 21, 2022. It is now read-only.
forked from cosmos/cosmos-sdk
-
Notifications
You must be signed in to change notification settings - Fork 8
add estimate gas process to get tx's real gas wanted #165
Open
louisliu2048
wants to merge
1
commit into
main
Choose a base branch
from
xiong/estimate-tx-gas
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,9 +3,11 @@ package context | |
import ( | ||
"fmt" | ||
"strings" | ||
"encoding/json" | ||
|
||
"github.com/tendermint/tendermint/crypto/tmhash" | ||
"github.com/tendermint/tendermint/mempool" | ||
"github.com/tendermint/tendermint/rpc/core" | ||
|
||
"github.com/cosmos/cosmos-sdk/client/flags" | ||
sdk "github.com/cosmos/cosmos-sdk/types" | ||
|
@@ -16,16 +18,16 @@ import ( | |
// based on the context parameters. The result of the broadcast is parsed into | ||
// an intermediate structure which is logged if the context has a logger | ||
// defined. | ||
func (ctx CLIContext) BroadcastTx(txBytes []byte) (res sdk.TxResponse, err error) { | ||
func (ctx CLIContext) BroadcastTx(txBytes []byte, estGasUse uint64) (res sdk.TxResponse, err error) { | ||
switch ctx.BroadcastMode { | ||
case flags.BroadcastSync: | ||
res, err = ctx.BroadcastTxSync(txBytes) | ||
res, err = ctx.BroadcastTxSync(txBytes, estGasUse) | ||
|
||
case flags.BroadcastAsync: | ||
res, err = ctx.BroadcastTxAsync(txBytes) | ||
res, err = ctx.BroadcastTxAsync(txBytes, estGasUse) | ||
|
||
case flags.BroadcastBlock: | ||
res, err = ctx.BroadcastTxCommit(txBytes) | ||
res, err = ctx.BroadcastTxCommit(txBytes, estGasUse) | ||
|
||
default: | ||
return sdk.TxResponse{}, fmt.Errorf("unsupported return type %s; supported types: sync, async, block", ctx.BroadcastMode) | ||
|
@@ -81,13 +83,22 @@ func CheckTendermintError(err error, txBytes []byte) *sdk.TxResponse { | |
// NOTE: This should ideally not be used as the request may timeout but the tx | ||
// may still be included in a block. Use BroadcastTxAsync or BroadcastTxSync | ||
// instead. | ||
func (ctx CLIContext) BroadcastTxCommit(txBytes []byte) (sdk.TxResponse, error) { | ||
func (ctx CLIContext) BroadcastTxCommit(txBytes []byte, estGasUse uint64) (sdk.TxResponse, error) { | ||
node, err := ctx.GetNode() | ||
if err != nil { | ||
return sdk.TxResponse{}, err | ||
} | ||
|
||
res, err := node.BroadcastTxCommit(txBytes) | ||
wMsg := core.WrapEthMsg { | ||
RawTxData: txBytes, | ||
EstimatedGasUse: estGasUse, | ||
} | ||
wTxBytes, err := json.Marshal(wMsg) | ||
if err != nil { | ||
return sdk.TxResponse{}, err | ||
} | ||
|
||
res, err := node.BroadcastTxCommit(wTxBytes) | ||
if err != nil { | ||
if errRes := CheckTendermintError(err, txBytes); errRes != nil { | ||
return *errRes, nil | ||
|
@@ -109,13 +120,22 @@ func (ctx CLIContext) BroadcastTxCommit(txBytes []byte) (sdk.TxResponse, error) | |
|
||
// BroadcastTxSync broadcasts transaction bytes to a Tendermint node | ||
// synchronously (i.e. returns after CheckTx execution). | ||
func (ctx CLIContext) BroadcastTxSync(txBytes []byte) (sdk.TxResponse, error) { | ||
func (ctx CLIContext) BroadcastTxSync(txBytes []byte, estGasUse uint64) (sdk.TxResponse, error) { | ||
node, err := ctx.GetNode() | ||
if err != nil { | ||
return sdk.TxResponse{}, err | ||
} | ||
|
||
res, err := node.BroadcastTxSync(txBytes) | ||
wMsg := core.WrapEthMsg { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🚫 [golangci] reported by reviewdog 🐶 |
||
RawTxData: txBytes, | ||
EstimatedGasUse: estGasUse, | ||
} | ||
wTxBytes, err := json.Marshal(wMsg) | ||
if err != nil { | ||
return sdk.TxResponse{}, err | ||
} | ||
|
||
res, err := node.BroadcastTxSync(wTxBytes) | ||
if errRes := CheckTendermintError(err, txBytes); errRes != nil { | ||
return *errRes, nil | ||
} | ||
|
@@ -125,13 +145,22 @@ func (ctx CLIContext) BroadcastTxSync(txBytes []byte) (sdk.TxResponse, error) { | |
|
||
// BroadcastTxAsync broadcasts transaction bytes to a Tendermint node | ||
// asynchronously (i.e. returns immediately). | ||
func (ctx CLIContext) BroadcastTxAsync(txBytes []byte) (sdk.TxResponse, error) { | ||
func (ctx CLIContext) BroadcastTxAsync(txBytes []byte, estGasUse uint64) (sdk.TxResponse, error) { | ||
node, err := ctx.GetNode() | ||
if err != nil { | ||
return sdk.TxResponse{}, err | ||
} | ||
|
||
res, err := node.BroadcastTxAsync(txBytes) | ||
wMsg := core.WrapEthMsg { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🚫 [golangci] reported by reviewdog 🐶 |
||
RawTxData: txBytes, | ||
EstimatedGasUse: estGasUse, | ||
} | ||
wTxBytes, err := json.Marshal(wMsg) | ||
if err != nil { | ||
return sdk.TxResponse{}, err | ||
} | ||
|
||
res, err := node.BroadcastTxAsync(wTxBytes) | ||
if errRes := CheckTendermintError(err, txBytes); errRes != nil { | ||
return *errRes, nil | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
WrapEthMsg not declared by package core (typecheck)