enable initial scroll #42
Conversation
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "react-scroll-sync", | |||
| "version": "0.0.0-development", | |||
| "version": "0.0.1-development", | |||
There was a problem hiding this comment.
Do not change the version. It's done automatically.
src/ScrollSync.js
Outdated
| }; | ||
|
|
||
| static childContextTypes = { | ||
| registerPane: PropTypes.func, | ||
| unregisterPane: PropTypes.func | ||
| } | ||
| }; |
|
@okonet should I get rid of yarn.lock and package-lock.json from the PR? |
|
You should not touch files that aren't related to the PR I'd suggest. |
|
@okonet removed those files from PR |
The semicolons came from prettier....
them semis
|
Build is still failing, though: |
|
@okonet hey, sorry for the late fix. I have just found out that this has yet to be merged, and I added a eslint ignore to ignore those errors..... Not sure why those errors didn't appear before though. |
|
|
||
| /* Calculate the actual pane height */ | ||
| const paneHeight = pane.scrollHeight - clientHeight | ||
| const paneWidth = pane.scrollWidth - clientWidth | ||
| /* Adjust the scrollTop position of it accordingly */ | ||
| if (vertical && scrollTopOffset > 0) { | ||
| pane.scrollTop = proportional ? (paneHeight * scrollTop) / scrollTopOffset : scrollTop // eslint-disable-line | ||
| if (!this.state.initialized) pane.scrollTop = initialScrollTop | ||
| // eslint-disable-next-line curly |
There was a problem hiding this comment.
Let's not disable this rule please and instead do what ESLint suggests.
| } | ||
| if (!this.state.initialized) this.state.initialized = true |
There was a problem hiding this comment.
I think React state should not be mutated like this. Either use setState or don't use state for it. Maybe that's there the ESLint error comes from?
Per my feature request #41
I have created a fork and allowed initial scroll position through two props
initialScrollLeftandinitialScrollTop