-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Functional Components, TypeScript Support, and Vite migration #101
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for taking on it. I was planning to do so but ended up re-implementing the library for a client. I think community could benefit from these changes. It would be great if you could address the feedback I left.
There are a few questions that needs to be resolved: notable the release process is not clear now. Previously I used semantic release AFAIK. How will the releases be managed with this change?
Also, are there any breaking changes?
I upgraded Node to v20 on netlify so let's see if it will be able to build after that. Push some changes to trigger a deploy preview please |
There aren't any "breaking changes" in this library. A bug fix around |
Would you consider adding the source code for the docs website here? I think it could use some modernizing: faq, more examples, etc |
The website code is here and is driven by styleguidist. I would keep it if possible |
Can you please check netlify build logs. Something is wrong with some dependencies. |
Could you add me to your netlify team? I think the issue is that it is caching old dependencies and we need to clean install |
styleguidist is not compatible with vite as far as I know. I lean towards Storybook as an easy way to generate docs. I would be open to creating the necessary stories and infra in the repo |
I see... yeah feel free to switch to storybook or another tool of your choice. Maybe a separate PR for that and then rebase this one on top? |
I tried to add you as a contributor but I don't know how to do that. Netlify mentions git contributors but again no idea how to add you. |
This is a huge pr with a lot of changes so feel free to give constructive feedback and I will try to address.