Upgrade to CKAN 2.10 #5
Conversation
| @@ -11,7 +11,7 @@ <h2>{{ _('Announcements to all users') }}</h2> | |||
| role="button" | |||
| class="btn btn-primary" | |||
| title="Schedule new message" | |||
| data-toggle="modal" | |||
| data-bs-toggle="modal" | |||
There was a problem hiding this comment.
If you are planning on supporting CKAN 2.9 (or CKAN 2.10 running on Bootstrap 3) you need to keep both attributes the new and the old version
There was a problem hiding this comment.
Updated here 55df8de @amercader
requirements.txt
Outdated
| @@ -1 +1,3 @@ | |||
| ckantoolkit | |||
| # remove when errors with "packaging" package is fixed | |||
| setuptools==65.3.0 | |||
There was a problem hiding this comment.
This will 100% cause problems down the line, extensions should not touch setuptools. What errors is this trying to fix?
There was a problem hiding this comment.
The error in the Install requirements test step was
Traceback (most recent call last):
File "/__w/ckanext-announcements/ckanext-announcements/setup.py", line 2, in
from setuptools import setup, find_packages
File "/usr/lib/python3.10/site-packages/setuptools/__init__.py", line 242, in
monkey.patch_all()
File "/usr/lib/python3.10/site-packages/setuptools/monkey.py", line 99, in patch_all
patch_for_msvc_specialized_compiler()
File "/usr/lib/python3.10/site-packages/setuptools/monkey.py", line [13](https://github.com/okfn/ckanext-announcements/actions/runs/5788357671/job/15687190753#step:6:14)6, in patch_for_msvc_specialized_compiler
msvc = import_module('setuptools.msvc')
File "/usr/lib/python3.10/importlib/__init__.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "/usr/lib/python3.10/site-packages/setuptools/msvc.py", line 32, in
from packaging.version import LegacyVersion
ImportError: cannot import name 'LegacyVersion' from 'packaging.version' (/usr/lib/python3.10/site-packages/packaging/version.py)
@amercader What do you think of moving this fix to tests? dec5378
ckanext/announcements/helpers.py
Outdated
| @@ -35,3 +35,8 @@ def get_all_announcements(): | |||
| ) | |||
|
|
|||
| return messages | |||
|
|
|||
|
|
|||
| def get_user_env(user_dict): | |||
There was a problem hiding this comment.
If this (really scary) function is only used in tests add it to the relevant test module and not the public helpers
There was a problem hiding this comment.
Updated here 4a08aeb and finally removed the helper here 95e68f9 @amercader
This PR update this extension to CKAN 2.10