-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: 프로젝트 추가 세팅 #2
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
5ac5b15
feat: 깃헙 issue, pull request 탬플릿 추가 #1
wjdtkdgns d22f5ab
feat: ktlint 추가 및 적용 #1
wjdtkdgns 5bb0223
feat: github action ci workflow ktlint check 로직 추가 #1
wjdtkdgns 83b4bb8
feat: jacoco 추가 #1
wjdtkdgns 30acd9e
feat: jacoco 관련 설정 추가 #1
wjdtkdgns a76c1ef
feat: sonarcube 설정 #1
wjdtkdgns e13c73f
feat: sonarcloud key 업데이트 #1
wjdtkdgns 1e7d00b
chore: ktlint 적용 #1
wjdtkdgns 381ceb6
fix: ci workflow ktlint_version 변경 #1
wjdtkdgns dd99c7e
fix: 리뷰 반영 및 workflow ktlint 버전 변경 #1
wjdtkdgns 5e8fad4
fix: workflow 조건 추가 및, ktlint 버전 변경 #1
wjdtkdgns 78b450d
imp: upgrade boot3 and jdk 17
DongGeon0908 e3740b9
fix: workflow ktlint version 삭제 #1
wjdtkdgns 9021638
fix: ktlint 로직 주석처리 #1
wjdtkdgns 4c2ae75
fix: workflow 수정 #1
wjdtkdgns f24747c
fix: docker-compose db 생성 변수 추가 #1
wjdtkdgns a064dd1
fix: sonarcube 버전 다운그레이드 및 ktlint 검증 로직 삭제 #1
wjdtkdgns fb7f3bf
feat: sonarqube run option 추가 #1
wjdtkdgns File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
[*.{kt,kts}] | ||
insert_final_newline=true | ||
ij_kotlin_allow_trailing_comma = true | ||
# ij_kotlin_allow_trailing_comma_on_call_site = true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
--- | ||
name: 'Issue: Enhancement' | ||
about: 새로운 기능 구현, 리팩토링과 관련된 이슈 템플릿 | ||
title: "🤖 [FEATURE]" | ||
labels: '' | ||
assignees: '' | ||
|
||
--- | ||
|
||
# 🤖 기능 개요 | ||
<!-- 이슈에 할당된 기능이 무엇인지 간략하게 한 줄로 적습니다 --> | ||
|
||
### ✅ Implement TODO | ||
<!-- 이슈에 할당된 TODO를 나름대로 항목화하여 적습니다 (PR할 때에는 모두 체크되어야함) --> | ||
- [ ] | ||
|
||
### 🚧 작업 브랜치 | ||
<!-- 작업 브랜치 이름 적어주세요 --> | ||
|
||
### 📚 Remarks | ||
<!-- 기능 개발에 있어 비고사항이 있었다면 적기 --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
--- | ||
name: 'Issue: Fix' | ||
about: 에러 및 버그에 관련된 이슈 템플릿 | ||
title: "🐞 [ERROR / BUG]" | ||
labels: '' | ||
assignees: '' | ||
|
||
--- | ||
|
||
# 🐞 에러 상황 설명 | ||
### 📄 에러 대상 | ||
<!-- 에러가 어디서 났는지 적기 --> | ||
|
||
### 🕵🏻♀️ 에러 상황 | ||
<!-- 에러가 어떻게 나고 있는지 상세하게 적기 (사진 있으면 첨부) --> | ||
|
||
### ✅ Resolve TODO | ||
<!-- 에러/버그 수정 항목 나열하기 (PR할 때에는 모두 체크되어야함) --> | ||
- [ ] | ||
|
||
### 🚧 작업 브랜치 | ||
<!-- 작업 브랜치 이름 적어주세요 --> | ||
|
||
### 📚 Remarks | ||
<!-- 이슈 해결에 있어 비고사항이 있었다면 적기 --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
--- | ||
name: "Issue: Refactor" | ||
about: 리팩토링 시에 적는 템플릿 | ||
title: "🔨[REFACTOR]" | ||
labels: '' | ||
assignees: '' | ||
|
||
--- | ||
|
||
# 🔨 리팩토링이 필요한 부분 | ||
<!-- 리팩토링 내용 --> | ||
|
||
### ✅ refactoring TODO | ||
<!-- 리팩토링 투두 --> | ||
|
||
### 🚧 작업 브랜치 | ||
<!-- 작업 브랜치 이름 적어주세요 --> | ||
|
||
### 📚 Remarks | ||
<!-- 기능 개발에 있어 비고사항이 있었다면 적기 --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
## 개요 | ||
- close #issueNumber | ||
|
||
## 작업사항 | ||
- 내용을 적어주세요. | ||
|
||
## 변경로직 | ||
- 내용을 적어주세요. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
name: CI | ||
|
||
on: | ||
pull_request: | ||
branches: | ||
- develop | ||
types: [ opened, synchronize, reopened ] | ||
|
||
jobs: | ||
build: | ||
name: CI | ||
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
kotlin-version: [ "1.8.22" ] | ||
java-version: [ "17" ] | ||
|
||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v3 | ||
with: | ||
fetch-depth: 0 | ||
|
||
- name: Set up Kotlin | ||
uses: actions/setup-java@v3 | ||
with: | ||
java-version: ${{ matrix.java-version }} | ||
kotlin-version: ${{ matrix.kotlin-version }} | ||
distribution: 'adopt' | ||
|
||
# 빌드, ktlint check도 진행됨 | ||
- name: Gradle Clean & Build | ||
run: ./gradlew clean build | ||
|
||
# 컨테이너 실행 | ||
- name: Start containers # test 돌릴때 mysql 필요 | ||
run: docker-compose up -d | ||
|
||
# jacoco, sonarcube | ||
- name: test and analyze | ||
run: ./gradlew test sonar --stacktrace | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUBTOKEN }} | ||
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,3 +35,5 @@ out/ | |
|
||
### VS Code ### | ||
.vscode/ | ||
|
||
mysqldata/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
# Spring Webflux + Coroutine Boilerplate | ||
|
||
### Spec | ||
- SpringBoot v2.7.17 | ||
- jdk 11 | ||
- SpringBoot v3.1.5 | ||
- jdk 17 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
version: '3.7' | ||
|
||
services: | ||
mysql: | ||
image: mysql | ||
container_name: mysql | ||
hostname: mysql | ||
volumes: | ||
- ./mysqldata:/var/lib/mysql | ||
environment: | ||
- MYSQL_USER=user | ||
- MYSQL_PASSWORD=user | ||
- MYSQL_ROOT_PASSWORD=root | ||
- MYSQL_HOST=localhost | ||
- MYSQL_PORT=3306 | ||
- MYSQL_DATABASE=test | ||
ports: | ||
- "3307:3306" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
src/main/kotlin/com/goofy/boilerplate/common/dto/ErrorResponse.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요기 신규 진행한거 저도 테스트를 해봐야 할 것 같어요