Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some incorrect documents in multiuser doc #640

Closed
wants to merge 5 commits into from

Conversation

kngwyu
Copy link

@kngwyu kngwyu commented Jun 18, 2024

Just removed a comma.

@kngwyu
Copy link
Author

kngwyu commented Jun 18, 2024

I noticed that there's a more serious mistake here (putting password to db), so I changed the doc accordingly.

@kngwyu kngwyu changed the title Fix typo in the SQL in multiuser doc Fix some incorrect documents in multiuser doc Jun 18, 2024
@@ -118,7 +118,7 @@ Follow the steps below to setup `multiuser` mode.
1. Install backend requirements
```bash
cd studio
pip install .
pip install -e .
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pip install . installs the packages into site-packages under the anaconda env without copying the config modified in the previous sections. So we need to use editable install or put config files under site-packages.

@itutu-tienday
Copy link
Collaborator

@kngwyu

Thank you very much.
We are planning to release the fixes related to your points in the following pull request.

@kngwyu
Copy link
Author

kngwyu commented Jul 9, 2024

Then can I close this one?

@kngwyu kngwyu closed this Jul 9, 2024
@kngwyu kngwyu deleted the typo-in-sql branch July 9, 2024 04:48
@itutu-tienday
Copy link
Collaborator

@kngwyu
Yes, the main branch has not been updated yet, but I think it's OK to close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants