Update to windows 0.58

[Jasper-Bekkers]

Not a huge change, this updates wmi-rs to windows 0.58

[ohadravid]

Thanks for taking the time to work on this 🎉

[ohadravid]

This will lose the original error code - would you mind adding the needed variant to the WMIError?

[Jasper-Bekkers]

It's slightly misleading but this calls https://docs.rs/windows-core/latest/windows_core/struct.HRESULT.html#method.ok which does retain the error code.

[ohadravid]

🤯

[Jasper-Bekkers]

Addressed all feedback, this should (tm) make the tests run again as well.

[ohadravid]

LGTM 🎉

[Jasper-Bekkers]

LGTM 🎉

Would you mind spinning a release if/when this lands?

[ohadravid]

Oh no:

> cargo test -- --nocapture --test-threads 1 it_can_desr_newtype_enum_field
...

Caused by:
  process didn't exit successfully: `... --nocapture --test-threads 1 _enum_fi` (exit code: 0xc0000005, STATUS_ACCESS_VIOLATION)

[Jasper-Bekkers]

My first guess would be a problem I've seen before with the implement macro but this requires a bit more investigation.

[ohadravid]

@Jasper-Bekkers - seems like an issue with IUnknown::from_raw, which should be the _borrowed version.

Can you merge the changes from my branch (https://github.com/ohadravid/wmi-rs/tree/update-win-0.58-fixes) into yours?

[Jasper-Bekkers]

@Jasper-Bekkers - seems like an issue with IUnknown::from_raw, which should be the _borrowed version.

Can you merge the changes from my branch (https://github.com/ohadravid/wmi-rs/tree/update-win-0.58-fixes) into yours?

Done - looks like it needed a cargo fmt still, so I pushed that. Thanks for taking the time to look into this.

[tim-weis]

Consider replacing this with

let bstr_borrow = ManuallyDrop::new(unsafe { BSTR::from_raw(vt.Anonymous.Anonymous.Anonymous.bstrVal) });
Variant::Sting(bstr_borrow.to_string())

This creates a non-owning BSTR from the get-go, so you do not have to remember and cannot forget to manually release ownership later.