Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Variant and SafeArray implementations #100

Merged
merged 4 commits into from
Sep 9, 2024
Merged

Improve Variant and SafeArray implementations #100

merged 4 commits into from
Sep 9, 2024

Conversation

ohadravid
Copy link
Owner

@ohadravid ohadravid commented Sep 8, 2024 •
edited
Loading

Safety:

  • In safearray: Now SafeArrayAccessor::new and safe_array_to_vec{_of_strings} are unsafe, as it is the caller's responsibility to pass valid arrays.
  • SafeArrayAccessor now exposes an iterator over the array (and not a slice), based on the data pointer+element count (vs the lower/upper bounds)

Other changes:

  • Variant::from_variant will now use windows-rs's VARIANT::to_string

@ohadravid ohadravid force-pushed the chore/variant-and-safearray-improvements branch from 35b0daa to c85b8fa Compare September 9, 2024 05:01
@ohadravid ohadravid marked this pull request as ready for review September 9, 2024 05:05
@ohadravid ohadravid enabled auto-merge September 9, 2024 05:05
@ohadravid ohadravid merged commit 5ba4022 into main Sep 9, 2024
8 checks passed
@ohadravid ohadravid deleted the chore/variant-and-safearray-improvements branch September 9, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ohadravid