Use IUnknown::from_raw_borrowed to avoid double free

ohadravid · Aug 27, 2024 · 7443a52 · 7443a52
1 parent 6271aa6
commit 7443a52
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/variant.rs b/src/variant.rs
@@ -168,8 +168,9 @@ impl Variant {
             VT_EMPTY => Variant::Empty,
             VT_NULL => Variant::Null,
             VT_UNKNOWN => {
-                let ptr = unsafe { IUnknown::from_raw(vt.Anonymous.Anonymous.Anonymous.punkVal) };
-                Variant::Unknown(IUnknownWrapper::new(ptr.clone()))
+                let ptr = unsafe { IUnknown::from_raw_borrowed(&vt.Anonymous.Anonymous.Anonymous.punkVal) };
+                let ptr = ptr.cloned().ok_or(WMIError::NullPointerResult)?;
+                Variant::Unknown(IUnknownWrapper::new(ptr))
             }
             _ => return Err(WMIError::ConvertError(variant_type)),
         };