-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: marshal pathItem and operation extentions #1269
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imports should be fixed and debug print should be removed.
It would be nice to have test to ensure that extensions are actually present in resulting JSON.
Anything else looks good to me.
@tdakkota concerns addressed 💅🏼 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1269 +/- ##
==========================================
+ Coverage 73.87% 73.90% +0.03%
==========================================
Files 189 189
Lines 12807 12855 +48
==========================================
+ Hits 9461 9501 +40
- Misses 2801 2805 +4
- Partials 545 549 +4 ☔ View full report in Codecov by Sentry. |
c830164
to
4024c9f
Compare
With entgo and entoas there is no easy way to attach custom extension to the
ogen.Spec
structure.x-gen
extentions logic was implemented here:Addresses #1228