Skip to content

Commit

Permalink
exclude not except. how embarrassing.
Browse files Browse the repository at this point in the history
  • Loading branch information
ofbeaton committed Feb 25, 2019
1 parent a3258e6 commit 39d79a1
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion phpcs/granite-docs/ruleset.xml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
-->
<!-- TODO: Create our own BlockComment class that allows single line variable hints for IDEs -->
<rule ref="Squiz.Commenting.BlockComment">
<except name="Squiz.Commenting.BlockComment.SingleLine"/>
<exclude name="Squiz.Commenting.BlockComment.SingleLine"/>
</rule>
<!-- TODO: Create our own ClassComment class that has the tags we want to require -->
<rule ref="Squiz.Commenting.ClassComment">
Expand Down
6 changes: 3 additions & 3 deletions phpcs/granite-syntax/ruleset.xml
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@
<rule ref="Squiz.WhiteSpace.CastSpacing">
<!-- let's try without these for PSR-12 adoption
allow blank lines above catch, elseif, else
<except name="Squiz.WhiteSpace.ControlStructureSpacing.SpacingBeforeClose"/>
<exclude name="Squiz.WhiteSpace.ControlStructureSpacing.SpacingBeforeClose"/>
-->
</rule>
<!-- TODO: force blank line above multiple catch, elseif, else -->
Expand All @@ -296,14 +296,14 @@
<rule ref="Squiz.WhiteSpace.FunctionClosingBraceSpace">
<!-- TODO: We may want to require 0 spaces before close, this one wants 1 -->
<!-- allow no blank lines before close -->
<except name="Squiz.WhiteSpace.FunctionClosingBraceSpace.SpacingBeforeClose"/>
<exclude name="Squiz.WhiteSpace.FunctionClosingBraceSpace.SpacingBeforeClose"/>
</rule>
<rule ref="Squiz.WhiteSpace.FunctionOpeningBraceSpace"/>

<!-- TODO: must allow no lines after class on last method of class -->
<rule ref="Squiz.WhiteSpace.FunctionSpacing">
<!-- allow no lines after method class, for last method in class -->
<except name="Squiz.WhiteSpace.FunctionSpacing.AfterLast"/>
<exclude name="Squiz.WhiteSpace.FunctionSpacing.AfterLast"/>
</rule>
<rule ref="Squiz.WhiteSpace.LogicalOperatorSpacing"/>
<rule ref="Squiz.WhiteSpace.MemberVarSpacing"/>
Expand Down

0 comments on commit 39d79a1

Please sign in to comment.