Add force fsync option to FileSink

odygrd · Sep 29, 2024 · a058985 · a058985
1 parent 59fec49
commit a058985
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/include/quill/sinks/FileSink.h b/include/quill/sinks/FileSink.h
@@ -405,17 +405,18 @@ class FileSink : public StreamSink
   /**
    * Fsync the file descriptor.
    */
-  void fsync_file() noexcept
+  void fsync_file(bool force_fsync = false) noexcept
   {
-    auto const now = std::chrono::steady_clock::now();
-
-    if ((now - _last_fsync_timestamp) < _config.minimum_fsync_interval())
+    if (!force_fsync)
     {
-      return;
+      auto const now = std::chrono::steady_clock::now();
+      if ((now - _last_fsync_timestamp) < _config.minimum_fsync_interval())
+      {
+        return;
+      }
+      _last_fsync_timestamp = now;
     }
 
-    _last_fsync_timestamp = now;
-
 #ifdef _WIN32
     FlushFileBuffers(reinterpret_cast<HANDLE>(_get_osfhandle(_fileno(_file))));
 #else

diff --git a/include/quill/sinks/RotatingFileSink.h b/include/quill/sinks/RotatingFileSink.h
@@ -380,7 +380,7 @@ class RotatingFileSink : public FileSink
 
     // We need to flush and also fsync before actually getting the size of the file
     FileSink::flush_sink();
-    FileSink::fsync_file(_file);
+    FileSink::fsync_file(true);
 
     if (_get_file_size(_filename) <= 0)
     {