Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yahboom k210 developer kit #46

Merged
merged 2 commits into from
Dec 24, 2024
Merged

Conversation

jdlcdl
Copy link

@jdlcdl jdlcdl commented Dec 15, 2024

What is this PR for?

an experimental support for the Yahboom-K210-Developer-Kit board (larger than yahboom module, w/ exposed headers on front)

Note: serial port not yet resolved... have not been able to connect via terminal then interrupt or start repl (even when compiler is configured)???

Beware: this board contains wifi hardware that could be enabled if jumpers were left on connecting IO pins 13,14, and 15 to esp-wifi pins tx, rx, and en respectively.

This new unsupported board pretends to be "yahboom" so that krux code is not changed.
The ./krux builder script would require building this board like ./krux build --unsupported maixpy_yahboom_devkit. It could later be flashed like a yahboom ./krux flash maixpy_yahboom as long as it was the last binary built.

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Docs update
  • Other

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.37%. Comparing base (7c4a02f) to head (c6a8410).
Report is 598 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #46      +/-   ##
===========================================
+ Coverage    91.45%   94.37%   +2.91%     
===========================================
  Files           56       74      +18     
  Lines         6967     8104    +1137     
===========================================
+ Hits          6372     7648    +1276     
+ Misses         595      456     -139     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdlcdl jdlcdl force-pushed the yahboom-k210-developer-kit branch from 6318ca5 to d705f19 Compare December 18, 2024 19:54
@jdlcdl jdlcdl force-pushed the yahboom-k210-developer-kit branch from d705f19 to c6a8410 Compare December 18, 2024 20:02
@odudex
Copy link
Owner

odudex commented Dec 19, 2024

Nice!
Could you do a PR of Maixpy changes? Could be directly in selfcustody's repo.

Copy link
Owner

@odudex odudex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great refactor, looks good to me!

@tadeubas
Copy link

Good idea to have to use allow_unsupported in the krux script. Couldn't be clearer!

@jdlcdl jdlcdl marked this pull request as ready for review December 23, 2024 18:53
@odudex odudex merged commit b4f011d into odudex:develop Dec 24, 2024
5 checks passed
@odudex
Copy link
Owner

odudex commented Dec 24, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants