입덕포인트 생성, 존재 유무 구현 #74 #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FaberJoo
reviewed
Nov 16, 2023
| @Transactional | ||
| public void save(Long memberId, AttractionPointReq req) { | ||
| if(checkAttractionPoint(memberId, req.getAnimeId()).getIsAttractionPoint()){ | ||
| throw new BadRequestException("AttractionPoint is already exists."); |
There was a problem hiding this comment.
중복 -> 충돌 -> 409 ConflictException 쓰시면 됩니다~
| .orElseThrow(() -> new NotFoundException("Anime")); | ||
|
|
||
|
|
||
| for(int i = 0; i < req.getAttractionElements().size(); i++){ |
jaycobcoder
approved these changes
Nov 18, 2023
FaberJoo
reviewed
Nov 18, 2023
| .anime(anime) | ||
| .attractionElement(attractionElement) | ||
| .build()) | ||
| .forEach(attractionPointRepository::save); |
There was a problem hiding this comment.
동일한 엔티티를 여러번 저장하는 경우, 리스트에 담아서 saveAll로 저장하는 걸 추천 드립니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 개요
입덕포인트 생성 및 존재 유무 구현
🚀 변경사항
🔗 관련 이슈
#74
➕ 기타