feat: 입덕 포인트 추가, 조회 구현 #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/303
|
로딩도 괜찮고 Deffer도 쓸수있을 것 같은데 UX 면에서 더 자연스러운쪽으로 고르면 좋을것같아요 |
chanwukim
approved these changes
Nov 23, 2023
presentKey
approved these changes
Nov 23, 2023
| key === "voiceActor" ? "VOICE_ACTOR" : key.toUpperCase(), | ||
| ) as AttractionType[]; | ||
|
|
||
| console.log("입덕 포인트: ", selectedAttraction); |
There was a problem hiding this comment.
요거는 입덕 포인트 수정까지 구현한 후에 제거하려고 합니다..!
Deploying with
|
| Latest commit: |
5889ec0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://459652c0.oduck-client.pages.dev |
| Branch Preview URL: | https://feature-303.oduck-client.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 개요
입덕 포인트 추가, 조회 구현
test.mp4
(현재 입덕 포인트에 DRAWING (그림체)를 포함할 경우 서버에서 500 응답이 옵니다.)
1.mp4
🚀 변경사항
🔗 관련 이슈
#303
➕ 기타
리뷰 수정 모달 띄울 때 내가 남긴 입덕 포인트 데이터가 살짝 늦게 적용이 되는데 그렇다고 입덕 포인트 데이터 요청을 모달 밖에서 수행하기엔 마이페이지 내 리뷰 목록 같은 곳에서는 리뷰 개수만큼 요청이 될 것 같기도 하고 좀 효율적이지 않다는 생각이 들어서 일단 이렇게 뒀는데 개선할 수 있는 방법이 있을까요?🤔 로딩중일 땐 로더 컴포넌트라도 넣어야 할지 고민입니다..
+ 11/23
test.mp4
defer 적용하였습니다!