[IMP] runbot: show state in favicon #994
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Williambraecky
commented
Nov 26, 2024
runbot/templates/utils.xml
Outdated
Comment on lines
23
to
24
| <link rel="icon" type="image/png" href="runbot/static/src/img/icon_ok.png"/> | ||
| <link rel="icon" type="image/svg+xml" href="/runbot/static/src/img/icon_ok.svg"/> |
There was a problem hiding this comment.
I added all icons as png and svg as not all browsers support svg favicons https://caniuse.com/link-icon-svg
Browser should be smart enough to know it can't load it :)
Until now the favicon was handled by the `/favicon.ico` route made available by `website`. This commit adds the different favicons and logic to be able to display the state of the current page through it.
Williambraecky
force-pushed
the
17.0-favicon-status-wbr
branch
from
0d99791
to
8cb25c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now the favicon was handled by the
/favicon.icoroute made available bywebsite.This commit adds the different favicons and logic to be able to display the state of the current page through it.