Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renku secret storage usage API documentation was added #117

Merged
merged 2 commits into from
Sep 3, 2024
Merged

renku secret storage usage API documentation was added #117

merged 2 commits into from
Sep 3, 2024

Conversation

okolo
Copy link
Contributor

@okolo okolo commented Aug 27, 2024

No description provided.

@okolo okolo linked an issue Aug 27, 2024 that may be closed by this pull request
add tutorial for renku secret usage #103
Closed
@okolo okolo requested a review from andriineronov August 27, 2024 11:06
@volodymyrss volodymyrss requested a review from ferrigno August 27, 2024 12:10
@ferrigno
Copy link
Contributor

What happens if the secret is not present as expected? Does it return None or an error. It is important for the implementation.
It would be useful to link the help page of oda_api.secret.get_secret() (with the function docstring)

ferrigno
ferrigno requested changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@ferrigno ferrigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add details on the function: parameters and return values (either link or text)

@okolo okolo requested a review from ferrigno September 3, 2024 04:36
@okolo okolo merged commit cde1cac into master Sep 3, 2024
2 checks passed
@okolo okolo deleted the 103-add-tutorial-for-renku-secret-usage branch September 3, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferrigno ferrigno ferrigno approved these changes

@andriineronov andriineronov Awaiting requested review from andriineronov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add tutorial for renku secret usage
2 participants
@okolo @ferrigno