Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not-Set token uploaded file url #719

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Conversation

burnout87
Copy link
Collaborator

Re-opening #718 .

After having discussed with @dsavchenko , the reason why the token was not added in the download url in the dispatcher was because this would impact the job_id calculation.

Reason why, it is handled at a nb2workflow level.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.06%. Comparing base (04a1d31) to head (81db20e).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #719      +/-   ##
==========================================
- Coverage   62.07%   62.06%   -0.01%     
==========================================
  Files          50       50              
  Lines        9141     9139       -2     
==========================================
- Hits         5674     5672       -2     
  Misses       3467     3467              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@burnout87 burnout87 marked this pull request as ready for review November 19, 2024 16:23
@burnout87 burnout87 merged commit d1d020b into master Nov 20, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants