Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix msgs readme #618

Merged
merged 24 commits into from
Nov 17, 2023
Merged

Matrix msgs readme #618

merged 24 commits into from
Nov 17, 2023

Conversation

burnout87
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #618 (f46360b) into master (ba7cdd2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #618   +/-   ##
=======================================
  Coverage   60.96%   60.96%           
=======================================
  Files          47       47           
  Lines        8472     8472           
=======================================
  Hits         5165     5165           
  Misses       3307     3307           

@burnout87 burnout87 marked this pull request as ready for review November 13, 2023 15:58
@burnout87 burnout87 merged commit 5b8c558 into master Nov 17, 2023
11 checks passed
@dsavchenko
Copy link
Member

Sorry for the late review

Probably it's better to move it to a separate file and have a link in the main README

Do we have a way to add matrix to the token, generated in frontend?

@burnout87
Copy link
Collaborator Author

Sorry for the late review

Probably it's better to move it to a separate file and have a link in the main README

Ok thanks, it makes sense

Do we have a way to add matrix to the token, generated in frontend?

yes, it will be added you can check oda-hub/mmoda-frontend-module#212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants