Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat|fix: generates models and fixes the tests #307

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

nickfloyd
Copy link
Contributor

This PR does two things:

  1. Generates the models using the latest schema
  2. Fixes the broken tree expression tests - This happened because optional arguments in this context are a feature of C# that doesn't have a direct representation in the expression tree format. So we had to pass all arguments to the expression (when defaults were present)

Before the change?

  • The tests failed
  • The models were out of date

After the change?

  • The query tests now run green
  • The models have been updated to the latest representation

@nickfloyd nickfloyd added Type: Bug Something isn't working as documented Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR labels Nov 3, 2023
Copy link

github-actions bot commented Nov 3, 2023

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@nickfloyd nickfloyd merged commit eef45a9 into main Nov 6, 2023
4 checks passed
@nickfloyd nickfloyd deleted the generate-models branch February 26, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants