Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test-new-project rule to Makefile. #398

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added test-new-project rule to Makefile. #398

wants to merge 1 commit into from

Conversation

sagotch
Copy link
Contributor

@sagotch sagotch commented Jan 11, 2017

This rule helps me a lot in testing ocsigen-start and should probably be included in the Makefile.

@dannywillems
Copy link
Member

dannywillems commented Feb 15, 2017

I agree with you @sagotch. Are the other changes still relevant and up-to-date? Could you remove the other changes about languages? It's old.

@sagotch
Copy link
Contributor Author

sagotch commented Feb 15, 2017

Force pushed without the changes about languages.

opam pin add ocsigen-start . -n -y \
&& opam reinstall -y ocsigen-start \
&& pushd /tmp \
&& rm -rf os_test \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe give the possibility to change the name? In a variable OS_PROJECTNAME?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to make a new pull request based on this one if you have time 👍

@jrochel jrochel force-pushed the master branch 2 times, most recently from 18b43bd to e093b83 Compare January 17, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants