Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate zh-tw to zh-hant #323

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

ben196888
Copy link
Collaborator

@ben196888 ben196888 commented Nov 25, 2023

Description

#318

Please add the description of the changes here.

BREAKING CHANGE

  • /zh-tw/* is no longer supported
  • /zh-Hant/* is in used
  • /zh-tw/* pages will redirect to /zh-Hant/* automatically

Impaction

Screenshots

No UI changes. All the mandarin pages are servable under /zh-Hant/* instead.

Performance

Build and deploy time

item Before After
w/ Cached 00m00s 00m00s
w/o Cached 00m00s 00m00s

Copy link

netlify bot commented Nov 25, 2023

Deploy Preview for openstartervillage ready!

Name Link
🔨 Latest commit b5f8ca6
🔍 Latest deploy log https://app.netlify.com/sites/openstartervillage/deploys/661d4b104b65d00008814222
😎 Deploy Preview https://deploy-preview-323--openstartervillage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 62
Accessibility: 95
Best Practices: 92
SEO: 92
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 25, 2023

Deploy Preview for openstartervillage-canary ready!

Name Link
🔨 Latest commit b5f8ca6
🔍 Latest deploy log https://app.netlify.com/sites/openstartervillage-canary/deploys/661d4b107707ef000760920f
😎 Deploy Preview https://deploy-preview-323--openstartervillage-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 63
Accessibility: 95
Best Practices: 92
SEO: 92
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ben196888 ben196888 force-pushed the refactor/rename-zh-tw-language-to-be-zh-hant branch from 04273f9 to b5f8ca6 Compare April 15, 2024 15:43
@ben196888 ben196888 changed the title wip: zh-tw to zh-hant refactor: migrate zh-tw to zh-hant Apr 15, 2024
@ben196888 ben196888 marked this pull request as ready for review April 15, 2024 15:45
@ben196888 ben196888 merged commit 2d120ac into main Apr 15, 2024
10 checks passed
@ben196888 ben196888 deleted the refactor/rename-zh-tw-language-to-be-zh-hant branch June 8, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant