Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add modal in cards #320

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Feat/add modal in cards #320

wants to merge 3 commits into from

Conversation

ljc1991
Copy link
Collaborator

@ljc1991 ljc1991 commented Nov 17, 2023

Description

  • Add react-bootstrap library (v1.6.7).
  • Add card modal in project cards.

minor

  • Move the entire card content to be presented in the card modal.

Impaction

Screenshots

Scenarios Before After
add btn 截圖 2023-11-17 20 56 14 截圖 2023-11-17 20 56 25
card modal N 截圖 2023-11-17 20 56 44

@ljc1991 ljc1991 requested a review from ben196888 November 17, 2023 13:04
Copy link

netlify bot commented Nov 17, 2023

Deploy Preview for openstartervillage-canary ready!

Name Link
🔨 Latest commit 2b8f135
🔍 Latest deploy log https://app.netlify.com/sites/openstartervillage-canary/deploys/655764db3b90c600080156db
😎 Deploy Preview https://deploy-preview-320--openstartervillage-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 66 (🟢 up 4 from production)
Accessibility: 95 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 17, 2023

Deploy Preview for openstartervillage ready!

Name Link
🔨 Latest commit 2b8f135
🔍 Latest deploy log https://app.netlify.com/sites/openstartervillage/deploys/655764dc6d5f170008a360fa
😎 Deploy Preview https://deploy-preview-320--openstartervillage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 63 (🟢 up 4 from production)
Accessibility: 95 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ben196888
Copy link
Collaborator

ben196888 commented Nov 25, 2023

Nice kickoff!

I think the card in a popup modal is a bit sqeezy in mobile. That would be great to make a specified card modal which the card border style is applied on and move the card titlte to modal header.

eg. draft
Screenshot 2023-11-17 at 22 44 32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants