Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add logo data in cms footer collection #309

Merged
merged 12 commits into from
Nov 4, 2023

Conversation

ljc1991
Copy link
Collaborator

@ljc1991 ljc1991 commented Oct 30, 2023

Description

Add footer logos to cms footer collection.

minor

  • Footer logos are generated from the cms.

@netlify
Copy link

netlify bot commented Oct 30, 2023

Deploy Preview for openstartervillage-canary failed.

Name Link
🔨 Latest commit 59d44b7
🔍 Latest deploy log https://app.netlify.com/sites/openstartervillage-canary/deploys/654637bba0bff80009755dbe

@netlify
Copy link

netlify bot commented Oct 30, 2023

Deploy Preview for openstartervillage failed.

Name Link
🔨 Latest commit 59d44b7
🔍 Latest deploy log https://app.netlify.com/sites/openstartervillage/deploys/654637bbbe2b0c000850005a

@ljc1991 ljc1991 requested a review from ben196888 October 30, 2023 09:06
@ben196888
Copy link
Collaborator

ben196888 commented Oct 31, 2023

Let's set the logo size is fixed as 170 * 34. consider to stretch the image if the image is smaller than this dimension.

@ljc1991
Copy link
Collaborator Author

ljc1991 commented Oct 31, 2023

Let's set the logo size is fixed as 170 * 34. consider to stretch the image if the image is smaller than this dimension.

I standardized the size of logos to 163x45, ensuring a uniform and complete presentation for all logos.

@ben196888 ben196888 force-pushed the feat/add-logo-data-in-cms-footer-collection branch from 60d026d to b0ef0da Compare November 3, 2023 10:27
@ben196888 ben196888 merged commit 3ed3d7d into main Nov 4, 2023
2 of 8 checks passed
@ben196888 ben196888 deleted the feat/add-logo-data-in-cms-footer-collection branch November 4, 2023 12:24
@ben196888 ben196888 restored the feat/add-logo-data-in-cms-footer-collection branch November 4, 2023 12:26
@ben196888 ben196888 deleted the feat/add-logo-data-in-cms-footer-collection branch November 4, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants