Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(homepage): add i18n navigation dropdown #289

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

ben196888
Copy link
Collaborator

Description

Add language dropdown menu in navigation bar

Major

  • Add language dropdown menu in navigation bar

Impaction

Screenshots

Please attach screenshots of UI accordingly. If you don't have any UI changes, please remove this section.

Scenarios Before After
Navigation Bar (desktop) Screenshot 2566-10-13 at 16 43 58 Screenshot 2566-10-13 at 16 44 46
Navigation Bar (mobile) Screenshot 2566-10-13 at 16 44 09 Screenshot 2566-10-13 at 16 44 23

Performance

Build and deploy time

item Before After
w/ Cached 00m00s 00m00s
w/o Cached 00m00s 00m00s

@netlify
Copy link

netlify bot commented Oct 13, 2023

Deploy Preview for openstartervillage-canary ready!

Name Link
🔨 Latest commit 9e7cb2b
🔍 Latest deploy log https://app.netlify.com/sites/openstartervillage-canary/deploys/6529123ffe4e8b000807ff22
😎 Deploy Preview https://deploy-preview-289--openstartervillage-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 69 (🔴 down 11 from production)
Accessibility: 95 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 13, 2023

Deploy Preview for openstartervillage ready!

Name Link
🔨 Latest commit 9e7cb2b
🔍 Latest deploy log https://app.netlify.com/sites/openstartervillage/deploys/6529123f41205c00087d0e5f
😎 Deploy Preview https://deploy-preview-289--openstartervillage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 88 (🟢 up 1 from production)
Accessibility: 95 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ben196888 ben196888 merged commit a76e99a into main Oct 13, 2023
@ben196888 ben196888 deleted the feature/i18n-nav-dropdown branch October 17, 2023 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant