You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 paths audited Performance: 88 (no change from production) Accessibility: 95 (no change from production) Best Practices: 83 (no change from production) SEO: 92 (no change from production) PWA: - View the detailed breakdown and full score reports
1 paths audited Performance: 86 (🟢 up 3 from production) Accessibility: 95 (no change from production) Best Practices: 83 (🔴 down 9 from production) SEO: 92 (no change from production) PWA: - View the detailed breakdown and full score reports
It's very good to have dynamic navigation links. 🥳 Nice work!
May I know your reason not to replace the hard code approach?
I think it will be better to wait until the content for the resource page is completely updated.
BTW, I haven't added the links to the cards page and activities page in the dynamic navigation list yet...
1. Add filter to check if the path and name in each page are empty
2. Add a hard-coded link to cards page
3. Remove the link to activities page
4. Replace page navigation list with dynamic page navigation list
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ben196888
deleted the
fix/adjust-navigation-bar-and-font-size-in-layout
branch
Description
minor
Impaction
Screenshots
Performance
Build and deploy time
N/A
LightHouse
N/A