Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to opam-file-format 2.2.0~alpha1 #6321

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kit-ty-kate
Copy link
Member

now depends on menhir instead of ocamlyacc.

Requires ocaml/opam-file-format#60

@kit-ty-kate kit-ty-kate added the PR: QUEUED Pending pull request, waiting for other work to be merged or closed label Dec 1, 2024
@kit-ty-kate kit-ty-kate added this to the 2.4.0~alpha1 milestone Dec 1, 2024
@kit-ty-kate kit-ty-kate marked this pull request as draft December 1, 2024 19:51
@kit-ty-kate
Copy link
Member Author

opam commands can be affected negatively (average of 15% performace loss for commands that require to parse opam files). Are there some known menhir options to improve performance?

@kit-ty-kate
Copy link
Member Author

reverting the hash-consing removal puts back the performances to their previous levels. However this is now not domain-safe anymore. I'll try to use Domain.DLS without pulling new dependencies on ocaml4 tomorrow

now depends on menhir instead of ocamlyacc
@kit-ty-kate kit-ty-kate force-pushed the opam-file-format-2.2.0 branch from c8e51bc to 0d3ca7c Compare December 11, 2024 15:53
@kit-ty-kate kit-ty-kate changed the title Upgrade to opam-file-format 2.2.0 Upgrade to opam-file-format 2.2.0~alpha1 Dec 11, 2024
@kit-ty-kate kit-ty-kate removed the PR: QUEUED Pending pull request, waiting for other work to be merged or closed label Dec 11, 2024
@kit-ty-kate kit-ty-kate marked this pull request as ready for review December 11, 2024 15:54
@kit-ty-kate kit-ty-kate requested a review from rjbou December 11, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant