Don't ask confirmation when pinning a new package #6309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
force-pushed
the
pin-no-ask
branch
from
258058d
to
f73569b
Compare
rjbou
reviewed
Nov 25, 2024
|
Discussion on dev meeting: We agree that the question is too much, but the information remains relevant as it may indicate that a repository is missing or that the package name is mistyped. |
kit-ty-kate
force-pushed
the
pin-no-ask
branch
from
f73569b
to
63bdee5
Compare
kit-ty-kate
commented
Nov 30, 2024
| (OpamConsole.colorise `bold "NEW")) | ||
| then raise Aborted; | ||
| if not (OpamPackage.has_name st.packages name) then | ||
| OpamConsole.note "Package %s was unknown until now" |
There was a problem hiding this comment.
If anyone has a better idea feel free to change it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3199
While reading #3199 i asked myself why this question was asked and i couldn't find any reason. It was added in #1335 with no reasoning behind it either.
In my opinion the question is redundant as the user is already asking to pin the package(s).