Ensure each repositories stored in repos-config is associated with an URL #6249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
force-pushed
the
repositories-no-url-opt
branch
from
6aa5792
to
5ece562
Compare
kit-ty-kate
added a commit
to ocaml-opam/opam-rt
that referenced
this pull request
Oct 17, 2024
rjbou
reviewed
Nov 18, 2024
I'm not sure to understand. Aside from crafting a custom repos-config file which can't happen in the wild i don't think there is a way to test this. |
|
That's the idea :) |
rjbou
force-pushed
the
repositories-no-url-opt
branch
from
5ece562
to
b52517c
Compare
rjbou
approved these changes
Nov 22, 2024
rjbou
force-pushed
the
repositories-no-url-opt
branch
from
b52517c
to
f0ddae3
Compare
kit-ty-kate
added a commit
to ocaml-opam/opam-rt
that referenced
this pull request
Nov 22, 2024
Apply changes from ocaml/opam#6249
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly cleanup work noticed as i was looking at implementing #5553.
Looking at the code of
OpamFile.Repos_config, i got surprised having repositories without any url was allowed ('a option) so i digged a little and it seems that theNonestate is not used anywhere:Missing repository URLrepos-configwould be accepted but ignored internally and i have no idea why it would ever be usedIn any case, this special case is not tested anywhere in the test-suite either so it looks reasonable to assume it was never meant to be handled, and reading the commit that added that possibility 667eacd, it seems to have been added with the idea that "it might be useful in the future", but 8 years later i don't think it turned out true at all.
ocaml-opam/opam-rt#79 should be merged first right before merging this PR