Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for opam-0install-cudf 0.5.0 #6130

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

kit-ty-kate
Copy link
Member

@kit-ty-kate kit-ty-kate commented Jul 30, 2024

Requires ocaml-opam/opam-0install-cudf#2
Requires ocaml-opam/opam-0install-cudf#3
Supersedes #5879

This PR also adds support for unordered criteria with 0install, as well as -changed and -count[avoid-version,solution] to make the solver prefer to keep packages installed at their current version and avoid packages marked with avoid-version respectively.

@kit-ty-kate kit-ty-kate added AREA: SOLVER PR: QUEUED Pending pull request, waiting for other work to be merged or closed labels Jul 30, 2024
@kit-ty-kate kit-ty-kate added this to the 2.3.0~alpha milestone Jul 30, 2024
@kit-ty-kate kit-ty-kate removed the PR: QUEUED Pending pull request, waiting for other work to be merged or closed label Aug 16, 2024
@kit-ty-kate kit-ty-kate marked this pull request as ready for review August 16, 2024 11:06
@kit-ty-kate kit-ty-kate requested a review from rjbou August 16, 2024 11:23
.github/workflows/ci.ml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
src/solver/opamBuiltin0install.ml Outdated Show resolved Hide resolved
Copy link
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the new module to index.html (it would have been a good test for the doc job!) and some comments in the nnew module mli.
lgtm, i'll let you check the new additions.
thanks!

@kit-ty-kate kit-ty-kate merged commit 4124b26 into ocaml:master Aug 20, 2024
39 checks passed
@kit-ty-kate kit-ty-kate deleted the 0install-cudf-0.5.0 branch August 20, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants