Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guardian is not compatible with OCaml 5.3 #27088

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

kit-ty-kate
Copy link
Member

Expects the effect keyword to be a identifier

#=== ERROR while compiling guardian.0.1.0 =====================================#
# context              2.4.0~alpha1~dev | linux/x86_64 | ocaml-variants.5.3.0+trunk | file:///home/opam/opam-repository
# path                 ~/.opam/5.3/.opam-switch/build/guardian.0.1.0
# command              ~/.opam/5.3/bin/dune build -p guardian -j 1 --promote-install-files=false @install
# exit-code            1
# env-file             ~/.opam/log/guardian-14-3b027a.env
# output-file          ~/.opam/log/guardian-14-3b027a.out
### output ###
# (cd _build/default && .ppx/34809d7e251114d06ac070567359e16e/ppx.exe --cookie 'library-name="guardian"' -o lib/guardian.pp.mli --intf lib/guardian.mli -corrected-suffix .ppx-corrected -diff-cmd - -dump-ast)
# File "lib/guardian.mli", line 184, characters 16-22:
# 184 |        and type effect = Effect.t
#                       ^^^^^^
# Error: Syntax error
# (cd _build/default && .ppx/34809d7e251114d06ac070567359e16e/ppx.exe --cookie 'library-name="guardian"' -o lib/guardian_entity.pp.ml --impl lib/guardian_entity.ml -corrected-suffix .ppx-corrected -diff-cmd - -dump-ast)
# File "lib/guardian_entity.ml", line 183, characters 14-20:
# 183 |      fun ?ctx effect ->
#                     ^^^^^^
# Error: Syntax error
# (cd _build/default && .ppx/34809d7e251114d06ac070567359e16e/ppx.exe --cookie 'library-name="guardian"' -o lib/persistence.pp.ml --impl lib/persistence.ml -corrected-suffix .ppx-corrected -diff-cmd - -dump-ast)
# File "lib/persistence.ml", line 7, characters 7-13:
# 7 |   type effect
#            ^^^^^^
# Error: Syntax error
# (cd _build/default && .ppx/34809d7e251114d06ac070567359e16e/ppx.exe --cookie 'library-name="Guardian_backend"' -o backend/mariadb_backend.pp.ml --impl backend/mariadb_backend.ml -corrected-suffix .ppx-corrected -diff-cmd - -dump-ast)
# File "backend/mariadb_backend.ml", line 82, characters 9-15:
# 82 |     type effect = Guard.Effect.t
#               ^^^^^^
# Error: Syntax error

Upstream ticket: uzh/guardian#20

@mseri mseri merged commit 400fbb0 into ocaml:master Dec 12, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants