Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New functions to retrieve position #155

Merged
merged 3 commits into from
Oct 16, 2023
Merged

New functions to retrieve position #155

merged 3 commits into from
Oct 16, 2023

Conversation

hhugo
Copy link
Contributor

@hhugo hhugo commented Oct 15, 2023

The goal is to improve the following pattern

let start, _ = Sedlexing.lexing_positions lb in
....
let _, stop = Sedlexing.lexing_positions lb in

@hhugo hhugo changed the title New functions to retrieve location New functions to retrieve position Oct 15, 2023
toots
toots approved these changes Oct 15, 2023
View reviewed changes
Copy link
Member

@toots toots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

pmetzger
pmetzger reviewed Oct 15, 2023
View reviewed changes
Copy link
Member

@pmetzger pmetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a very trivial comment.

CHANGES.md Outdated Show resolved Hide resolved
@toots
Copy link
Member

toots commented Oct 16, 2023

Thanks for fixing the typos! I think that this is good to go!

@toots toots merged commit ccd3dea into ocaml-community:master Oct 16, 2023
9 checks passed
@hhugo hhugo deleted the hhapi branch October 16, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmetzger pmetzger pmetzger left review comments

@toots toots toots approved these changes

@alainfrisch alainfrisch Awaiting requested review from alainfrisch alainfrisch is a code owner

@Drup Drup Awaiting requested review from Drup Drup is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hhugo @toots @pmetzger