Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtmp-service: Add bitwave.tv #4376

Closed

Conversation

DispatchCommit
Copy link

Description

Adds bitwave.tv to RTMP services.

Motivation and Context

Provide a simple method within OBS to connect to our service while also pre-configuring some settings that improve compatibility with our livestream ingestion and help reduce delay.

Location Documenting OBS Profile & Tune for service: bitwave-tv/bitwave#215

(disclosure: I am the developer for bitwave)

How Has This Been Tested?

Tested on Windows 10 PC (as of 2021.03.18) to Primary ingestion server listed.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@dodgepong
Copy link
Member

Are you sure you want your users to experience a massive degradation in video quality for a very minor improvement in latency by using tune=zerolatency?

@DispatchCommit
Copy link
Author

Are you sure you want your users to experience a massive degradation in video quality for a very minor improvement in latency by using tune=zerolatency?

Hmmm, you make a valid point, this may be more than absolutely necessary and may have a negative impact. I've been using NVENC more than h264 lately as well, and don't remember seeing any noticeable reduction in delay using zerolatency with 1 to 2 second HLS segment files anyways. So the trade off may not be worth it. I'll leave that up to streamers to play with and decide for themselves. If it becomes an issues, I'll just PR again with an update.

Zerolatency might be one of those things that sounds like what you want to use, but doesn't actually have a large effect, but has been recommended incorrectly to people repeatedly because it sounds like the "right" tune to use.

I've rebased and force-pushed removing the tune for this PR.

@WizardCM WizardCM added the Services These are modifications to the Service list and are not tied to the release schedule label Mar 20, 2021
@DispatchCommit
Copy link
Author

@beans-coding PR's are not personal forum

But just to shut down this discussion early, the article you linked also names Twitch and Dlive

Miller has streamed content using platforms such as DLive, Twitch and Bitwave.Tv.

Both services are also in this file though - yet you do not take issue with that. Lastly, there is only so much solo or small dev teams can do to manage a rapidly growing platform.

Please, if you would like to help though, our code is open source and help is always appreciated! :)

Thanks for the feedback, but lets please remain on topic.

@rogue-ronin
Copy link

rogue-ronin commented Mar 20, 2021

@beans-coding PR's are not personal forum
But just to shut down this discussion early, the article you linked also names Twitch and Dlive

Miller has streamed content using platforms such as DLive, Twitch and Bitwave.Tv.
Both services are also in this file though - yet you do not take issue with that. Lastly, there is only so much solo or small dev teams can do to manage a rapidly growing platform.
Please, if you would like to help though, our code is open source and help is always appreciated! :)
Thanks for the feedback, but lets please remain on topic.

You don't get to decide what people think is important. If you are allowing neo-nazis and hate speech on your platform I also don't think that OBS developers should assist you with your efforts to "rapidly expand". Actually, dealing with it before you expand is the proper way to handle it.

You diverted the discussion away from the claim that you support hate-speech and vile imagery on your platform into focusing on the example person given, and attempting to broaden it to include twitch and dlive. Nobody is asking you to take responsibility for twitch or dlive, they are asking you to take responsibility for bitwave. So talk about that instead of trying to distract.

Answer the implied question: are you allowing hate speech and imagery on your platform? Avoid the whataboutism (Twitter is doing it too!) and speak to the problem. Or, if you don't think that neo-nazis and hate speech are a problem, clearly state it.

But pretending that you are above it, or that it's irrelevant, is the standard path of the enabler - if not the enactor.

PS: I note that the example person has been banned from twitch and dlive, but not from bitwave.tv

@Fenrirthviti
Copy link
Member

Given the testimony above, and our own research, we have decided to decline adding bitwave.tv to our services list at this time. Thank you for the submission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Services These are modifications to the Service list and are not tied to the release schedule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants