-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Missing Encoder Check on Startup/Profile load #11340
Open
derrod
wants to merge
3
commits into
obsproject:master
Choose a base branch
from
derrod:startup-nvenc-check
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+252
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notr1ch
reviewed
Oct 3, 2024
RytoEX
requested changes
Oct 3, 2024
derrod
force-pushed
the
startup-nvenc-check
branch
3 times, most recently
from
October 5, 2024 00:33
67244b2
to
75b14b1
Compare
derrod
force-pushed
the
startup-nvenc-check
branch
from
October 5, 2024 22:20
75b14b1
to
4a66a47
Compare
derrod
changed the title
WIP: Encoder Missing Warning
Add Missing Encoder Check on Startup/Profile load
Oct 5, 2024
derrod
force-pushed
the
startup-nvenc-check
branch
from
October 5, 2024 22:40
4a66a47
to
c25ecb2
Compare
WizardCM
added
Seeking Testers
Build artifacts on CI
UI/UX
Anything to do with changes or additions to UI/UX elements.
labels
Oct 5, 2024
derrod
force-pushed
the
startup-nvenc-check
branch
3 times, most recently
from
October 7, 2024 22:31
e97f60f
to
ecfc615
Compare
I'd like to adjust the formatting of this a little bit to group the errors with the encoder it's for There were errors with one or more encoders: obs_nvenc_hevc_texNVENC check failed with reason: Outdated driver (code: outdated_driver) obs_nvenc_anotherMiscellaneous probme (code: bad_nibbles) See the Knowledge Base Article for further information <li>
<h3></h3>
<code><code>
</li> |
derrod
force-pushed
the
startup-nvenc-check
branch
2 times, most recently
from
November 1, 2024 00:53
5fbc505
to
042ffc6
Compare
Yeah the error string for NVENC originally included the code as well and I forgot to remove that. |
derrod
force-pushed
the
startup-nvenc-check
branch
2 times, most recently
from
November 18, 2024 22:37
e176e85
to
f7603ef
Compare
derrod
force-pushed
the
startup-nvenc-check
branch
from
January 17, 2025 23:08
f7603ef
to
5fe1aa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
New Feature
New feature or plugin
Seeking Testers
Build artifacts on CI
UI/UX
Anything to do with changes or additions to UI/UX elements.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds additional checks to the nvenc test binary, and uses it to show a descriptive error message on startup if NVENC was selected and is now missing.
Example:
Motivation and Context
Want to make it more obvious to users why NVENC has gone missing, especially those with Kepler GPUs.
How Has This Been Tested?
Tested with modifications to the nvenc test binary to produce various error codes.
Types of changes
Checklist: