Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing Encoder Check on Startup/Profile load #11340

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

derrod
Copy link
Member

@derrod derrod commented Oct 3, 2024

Description

Adds additional checks to the nvenc test binary, and uses it to show a descriptive error message on startup if NVENC was selected and is now missing.

Example:
Example Warning Screenshot

Motivation and Context

Want to make it more obvious to users why NVENC has gone missing, especially those with Kepler GPUs.

How Has This Been Tested?

Tested with modifications to the nvenc test binary to produce various error codes.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

UI/window-basic-main-profiles.cpp Outdated Show resolved Hide resolved
UI/window-basic-main-profiles.cpp Outdated Show resolved Hide resolved
UI/window-basic-main-profiles.cpp Outdated Show resolved Hide resolved
UI/window-basic-main-profiles.cpp Outdated Show resolved Hide resolved
@derrod derrod force-pushed the startup-nvenc-check branch 3 times, most recently from 67244b2 to 75b14b1 Compare October 5, 2024 00:33
@WizardCM WizardCM added the New Feature New feature or plugin label Oct 5, 2024
@derrod derrod force-pushed the startup-nvenc-check branch from 75b14b1 to 4a66a47 Compare October 5, 2024 22:20
@derrod derrod changed the title WIP: Encoder Missing Warning Add Missing Encoder Check on Startup/Profile load Oct 5, 2024
@derrod derrod marked this pull request as ready for review October 5, 2024 22:21
@derrod derrod force-pushed the startup-nvenc-check branch from 4a66a47 to c25ecb2 Compare October 5, 2024 22:40
@WizardCM WizardCM added Seeking Testers Build artifacts on CI UI/UX Anything to do with changes or additions to UI/UX elements. labels Oct 5, 2024
@RytoEX RytoEX requested review from notr1ch and Warchamp7 October 7, 2024 17:53
@derrod derrod force-pushed the startup-nvenc-check branch 3 times, most recently from e97f60f to ecfc615 Compare October 7, 2024 22:31
@Warchamp7
Copy link
Member

Warchamp7 commented Oct 21, 2024

I'd like to adjust the formatting of this a little bit to group the errors with the encoder it's for


There were errors with one or more encoders:

obs_nvenc_hevc_tex

NVENC check failed with reason: Outdated driver (code: outdated_driver)

obs_nvenc_another

Miscellaneous probme (code: bad_nibbles)

See the Knowledge Base Article for further information


<li>
<h3></h3>
<code><code>
</li>

@derrod
Copy link
Member Author

derrod commented Nov 1, 2024

Updated it based on that, looks like this now:

screenshot revised

@derrod derrod force-pushed the startup-nvenc-check branch 2 times, most recently from 5fbc505 to 042ffc6 Compare November 1, 2024 00:53
@Warchamp7
Copy link
Member

Updated it based on that, looks like this now:

screenshot revised

Looks good aside from the code: outdated_driver getting double reported on the NVENC entries. Is NVENC including that as part of their error message?

@derrod
Copy link
Member Author

derrod commented Nov 18, 2024

Yeah the error string for NVENC originally included the code as well and I forgot to remove that.

See https://github.com/obsproject/obs-studio/pull/11340/files#diff-cd50d66da1e02db4fa473b80d6109b5799b4e619d09ac4e4487e4492ded51fc8R1604

@derrod derrod force-pushed the startup-nvenc-check branch 2 times, most recently from e176e85 to f7603ef Compare November 18, 2024 22:37
@derrod derrod force-pushed the startup-nvenc-check branch from f7603ef to 5fe1aa3 Compare January 17, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature New feature or plugin Seeking Testers Build artifacts on CI UI/UX Anything to do with changes or additions to UI/UX elements.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

5 participants