Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable exporting CMake interface target #10100

Conversation

tytan652
Copy link
Collaborator

@tytan652 tytan652 commented Jan 13, 2024

Description

Required by:

Motivation and Context

Needed to enable installing obs-websocket-api and obs-browser-api headers

How Has This Been Tested?

Build on Linux (still uses legacy path) with obs-browser-api PR and check if the header is installed, which is the case.

Ci for Windows and macOS, headers install needs to be checked locally

  • Tested on Windows, --component Development adds the header

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@tytan652 tytan652 marked this pull request as draft January 13, 2024 15:13
@tytan652 tytan652 changed the title cmake: Skip generate export header if interface in legacy path Enable exporting CMake interface target Jan 13, 2024
@tytan652 tytan652 marked this pull request as ready for review January 13, 2024 15:21
@tytan652 tytan652 added the Enhancement Improvement to existing functionality label Jan 13, 2024
@RytoEX RytoEX requested a review from PatTheMav January 13, 2024 21:20
@tytan652 tytan652 force-pushed the backport_no_generate_export_header_in_cmake2 branch from 50da790 to e09c99e Compare January 16, 2024 18:44
@tytan652 tytan652 force-pushed the backport_no_generate_export_header_in_cmake2 branch from e09c99e to 142be91 Compare January 27, 2024 11:03
@WizardCM WizardCM merged commit 7c2b394 into obsproject:master Jan 28, 2024
14 checks passed
@RytoEX RytoEX added this to the OBS Studio (Next Version) milestone Jan 28, 2024
@tytan652 tytan652 deleted the backport_no_generate_export_header_in_cmake2 branch January 28, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants