Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Source events in Readme #461

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aquarion
Copy link

Description

Split the Javascript events into two lists, and explicitly stated what the Source events react to.

Motivation and Context

The Source events aren't documented with the rest of the events in the OBS source, and the Readme needs a bit of clarification that they're only firing when the browser source changes.

This was suprising to me, so I'm documenting it to avoid suprising others.

How Has This Been Tested?

Text change. Checked for spelling changes.

Types of changes

Documention change.

Checklist:

  • [/] My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

The Source events aren't documented with the rest of the events in the OBS source, and the Readme needs a bit of clarification that they're only firing when the **browser** source changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant