Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle Enter key event for IME inputs #3272

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ryotatake
Copy link

@ryotatake ryotatake commented Jan 13, 2025

Types of changes

Description

“Create or edit Task" Modal input, there was a conflict between the Enter key event used to confirm IME conversions and the Enter key event used to create tasks, causing unintended behavior.

This has been corrected so that the Enter key is not used to create a task when the IME conversion is confirmed.

Motivation and Context

How has this been tested?

Manually tested the following

  • When using IME, the task is not created when the conversion is confirmed with the Enter key. When the Enter key is pressed again, the task is created.
  • When IME is not used, the task is created when the Enter key is pressed.

Screenshots (if appropriate)

before fix

IME_input.mov

after fix

IME_input_after_fix.mov

Checklist

  • My code follows the code style of this project and passes yarn run lint.
  • [-] My change requires a change to the documentation.
  • [-] I have updated the documentation accordingly.
  • My change has adequate Unit Test coverage.
    • I was not sure if testing was needed for this change, so please let me know if it is needed.

Terms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant